#5 - Fix infinite hanging frontend:dev Wails command#6
Open
Insulince wants to merge 1 commit intoTAINCER:masterfrom
Open
#5 - Fix infinite hanging frontend:dev Wails command#6Insulince wants to merge 1 commit intoTAINCER:masterfrom
frontend:dev Wails command#6Insulince wants to merge 1 commit intoTAINCER:masterfrom
Conversation
nasuadachi
approved these changes
Oct 20, 2022
marcio199226
approved these changes
Mar 16, 2023
marcio199226
left a comment
There was a problem hiding this comment.
This definitely resolve the issue
|
This solves the problem |
|
Pretty sure this solves the issue |
|
I'm quite confident this resolves the issue. |
Ecsodikas
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
frontend:devWails command running an npm command which never exits.So, the initial closed pipe error appears to be because
npm installwas never run after pulling a fresh instance of the template, so attempting tong buildwould error out. And this error isn't propagated, hence the cryptic message about the pipe closing.Running
npm installfixes the pipe error, however, it then runs into another issue which is that Wails hangs forever while it states it's attempting to install front-end dependencies. It isn't installing dependencies, it's runningnpm run watchwhich runsng build --watch .... Because of the--watchflag, it hangs forever since this command never exits.The fix for this was to simply add a new
npmcommand calledbuild:devfor doing a one-off build identical to thewatchcommand except without the--watchflag so that it eventually terminates and allows the program to proceed, and assign it to the Wails commandfrontend:dev, then move thenpm run watchcommand to the Wails commandfrontend:dev:watcher. After these changes my issues have gone away and things like hot reloading appear to be operating just fine.I will say though, that it is still important that somehow it be communicated that
npm installneeds to be run to avoid the pipe error on a fresh instance of the template. Though installing dependencies is a pretty standard requirement after pulling a fresh front-end project, perhaps it's not that huge of a deal.